-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance/stdlib #1600
Maintenance/stdlib #1600
Conversation
1ca6f8d
to
a457c3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small things to consider,
I think that we can switch in this PR to c++23 and use std::print
05deba5
to
88ad5c7
Compare
2bd1e14
to
0d594c2
Compare
026abfe
to
29c61f9
Compare
Other changes: - [crispy] App: Changes log timestamps to print time in local time - Drop Ubuntu 20.04 and Ubuntu 22.04 CI pipline building and tests Signed-off-by: Christian Parpart <christian@parpart.family>
29c61f9
to
87bde6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks, I think we can merge it
just one file in scripts not sure that we need it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can use install-deps.sh to get all dependencies, why this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we call it twice. I'd prefer to maintain the actual dependencies to install in as few locations as possible :)
Which file? I am in the forest right now. It's hard to check on the phone :) |
|
CHECKLIST BEFORE MERGE
How:
misc notes
%H:%S
is working correctlyfmt::runtime()
have been rewrittenfmt::arg()
rewritten forstd::format()
Closes #1598